Skip to content

Conversation

joshuacuellar1
Copy link
Contributor

Purpose of this PR

The purpose is to support Kubernetes v1.33.0.

Proposed changes:

  • Updates the Kubernetes packages to v0.33.0
  • Updates Helm to v3.18.2, because the Helm versions built with support for Kubernetes v1.33.0 are v3.18.0, v3.18.1, and v3.18.2
  • Update generated files
  • sigs.k8s.io/controller-runtime now deprecates reconcile.Result.Requeue. When the reconcile functions return errors, they should automatically re-queue, and if you need to re-queue without returning an error you can use reconcile.Result.RequeueAfter.
  • Kubernetes 1.33 and above deprecated the Endpoints API (link), and it has been replaced with the EndpointSlices API. I rewrote the portion of the tests that used the Endpoints API to use the EndpointSlices API.

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

The latest versions of Apache Spark now support Kubernetes v1.33.0. Actually, Spark 4.0.0 removes support for all versions below v1.30 (link), so you could consider dropping support from some of the older versions in CI.

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

@google-oss-prow google-oss-prow bot requested review from ImpSy and nabuskey July 8, 2025 23:25
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yuchaoran2011 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

github-actions bot commented Oct 7, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant