Skip to content

Add support to provisioning vcloud workers with multiple nics/networks #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support to provisioning vcloud workers with multiple nics/networks #1941

wants to merge 1 commit into from

Conversation

4ch3los
Copy link

@4ch3los 4ch3los commented Jun 25, 2025 •
edited
Loading

What this PR does / why we need it:
This pr adds the ability to create machines in vmware cloud director with multiple nics using different networks. This is especially useful when you want to use a additional nic for storage

Which issue(s) this PR fixes:

What type of PR is this?

/kind feature

Special notes for your reviewer:

This change just adds the nic to the vm, for the configuration there is a osm pr kubermatic/operating-system-manager#471

Does this PR introduce a user-facing change? Then add your Release Note here:

Added the option to provision vmware cloud director nodes with multiple networks/nics

Documentation:

TBD

@kubermatic-bot kubermatic-bot added docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jun 25, 2025
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mohamed-rafraf for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2025
@kubermatic-bot
Copy link
Contributor

Hi @4ch3los. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 25, 2025
@4ch3los 4ch3los mentioned this pull request Jun 25, 2025
Merged
@4ch3los 4ch3los changed the title feat: Add support to provisioning vcloud workers with multiple nics/networks Add support to provisioning vcloud workers with multiple nics/networks Jun 25, 2025
@4ch3los 4ch3los mentioned this pull request Jun 25, 2025
Open
@kron4eg
Copy link
Member

kron4eg commented Jul 29, 2025

/cc

@kubermatic-bot kubermatic-bot requested a review from kron4eg July 29, 2025 13:18
kron4eg
kron4eg requested changes Jul 29, 2025
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

pkg/cloudprovider/provider/vmwareclouddirector/provider.go
if err != nil {
return nil, nil, nil, err
}

if singleNetwork != "" && len(rawConfig.Networks) == 0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why only if len(Networks) == 0? I suggest to use it anyway, as a first c.Networks element.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change that if you want, my thoughts were, that you would use one of both and not both, but it wouldnt hurt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, since this commit will deprecate a single Network and suggest to use []Network in code we'd want to use only the new way and somehow convert the old deprecated single Network to the new []Network.

My suggestion is this exact convertion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg requested changes

Assignees

@kron4eg kron4eg

Labels
dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4ch3los @kubermatic-bot @kron4eg