feat: add yaml processor to create/delete resources from yaml manifest files by kocarba · Pull Request #2377 · kubernetes-client/python

kocarba · 2025-03-26T04:26:58Z

Implement delete_from_yaml functionality
Combine create_from_yaml and delete_from_yaml into yaml_processor, preserving existing signatures for create
(original PR Delete kubernetes resources from yaml files , solves #940 #1392 by @DiptoChakrabarty)

What type of PR is this?

/kind feature

What this PR does / why we need it:

The kubernetes python client has the ability to create resources from yaml files but lacks the ability to delete resources from yaml files. A delete action is provided to delete kubernetes resources in addition to the existing create.

This closes a long standing feature request in #940, and refactors the existing logic into a combined internal module while preserving backwards compatibility for existing users.

Which issue(s) this PR fixes:

Fixes #940

Special notes for your reviewer:

Original implementation started in PR Delete kubernetes resources from yaml files , solves #940 #1392 by @DiptoChakrabarty
This PR revives and modernizes that work, rebased on latest master
All relevant tests pass locally; 4 unrelated (outside of scope of change) test failures/errors occur before and after changes

Does this PR introduce a user-facing change?

Added the ability to choose to create or delete resources from yaml manifest files.
Refactored into a new internal `yaml_processor` module (backwards-compatible).

linux-foundation-easycla · 2025-03-26T04:27:02Z

The committers listed above are authorized under a signed CLA.

✅ login: kocarba (b18352f, 5f486fb)

k8s-ci-robot · 2025-03-26T04:27:06Z

Welcome @kocarba!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

…fest files

roycaihw · 2025-03-26T20:04:41Z

/assign @yliaog

ThisIsQasim · 2025-04-10T13:54:38Z

kubernetes/utils/yaml_processor.py

+                body=yml_object, field_manager="python-client", **kwargs
+            )
+        elif action == "delete":
+            resp = apply_client.delete(


DynamicClient delete function only takes the resource name

Suggested change

resp = apply_client.delete(

name = yml_object["metadata"]["name"]

resp = apply_client.delete(

body=yml_object, field_manager="python-client", **kwargs

)

Thank you for the feedback, @ThisIsQasim. I updated the code based on your suggestions. 5f486fb

Summary of changes:

Modify the delete method call to use the name only

Add an E2E test for process_from_yaml with the arguments for apply and action

Let me know if anything else needs adjustment, or if this looks good to you.

Hey @kocarba,
Thanks for the fix but unfortunately I am not a maintainer so can’t review/merge. Also I ended up switching to https://github.com/tomplus/kubernetes_asyncio

k8s-ci-robot · 2025-04-20T19:23:33Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kocarba
Once this PR has been reviewed and has the lgtm label, please ask for approval from yliaog. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-triage-robot · 2025-08-24T17:23:59Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ThisIsQasim · 2025-08-24T17:39:43Z

/remove-lifecycle stale

k8s-triage-robot · 2025-11-22T18:28:17Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2025-12-22T18:58:07Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2026-01-21T19:28:34Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2026-01-21T19:28:39Z

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot requested review from roycaihw and yliaog March 26, 2025 04:27

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 26, 2025

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 26, 2025

kocarba changed the title ~~Revive PR #1392: solves #940 and update to latest~~ feature: Revive PR #1392: solves #940 and update to latest Mar 26, 2025

kocarba changed the title ~~feature: Revive PR #1392: solves #940 and update to latest~~ feature: add yaml processor to create/delete resources from yaml manifest files Mar 26, 2025

feature: add yaml processor to create/delete resources from yaml mani…

b18352f

…fest files

kocarba force-pushed the pr/create-delete-utils branch from 73aeb93 to b18352f Compare March 26, 2025 04:48

kocarba changed the title ~~feature: add yaml processor to create/delete resources from yaml manifest files~~ feat: add yaml processor to create/delete resources from yaml manifest files Mar 26, 2025

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 26, 2025

k8s-ci-robot assigned yliaog Mar 26, 2025

ThisIsQasim reviewed Apr 10, 2025

View reviewed changes

Resolve DynamicClient delete function only takes the resource name

5f486fb

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2025

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2025

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 22, 2025

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 22, 2025

k8s-ci-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 22, 2025

k8s-ci-robot closed this Jan 21, 2026

Conversation

kocarba commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

linux-foundation-easycla bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Mar 26, 2025

Uh oh!

roycaihw commented Mar 26, 2025

Uh oh!

ThisIsQasim Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

kocarba May 26, 2025

Choose a reason for hiding this comment

Uh oh!

ThisIsQasim May 26, 2025

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Apr 20, 2025

Uh oh!

k8s-triage-robot commented Aug 24, 2025

Uh oh!

ThisIsQasim commented Aug 24, 2025

Uh oh!

k8s-triage-robot commented Nov 22, 2025

Uh oh!

k8s-triage-robot commented Dec 22, 2025

Uh oh!

k8s-triage-robot commented Jan 21, 2026

Uh oh!

k8s-ci-robot commented Jan 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kocarba commented Mar 26, 2025 •

edited

Loading

linux-foundation-easycla bot commented Mar 26, 2025 •

edited

Loading