-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Kubernetes Python Client to return "Terminating" for terminating pods #2425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: p172913 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign |
if response_type == "V1PodList": | ||
for pod in result.items: | ||
if pod.metadata and pod.metadata.deletion_timestamp: | ||
pod.status.phase = "Terminating" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be more of a request to change the upstream API behavior. You may want to check with upstream Kubernetes on the behavior here.
IIUC you're expecting the pod status to be marked Terminating
if the deletion timestamp is set. What did you see before this change?
Also this is generated code, so we should not change it directly.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR makes Kubernetes Python Client to return "Terminating" for terminating pods
Which issue(s) this PR fixes:
Fixes #2397
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
None
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
None