-
Notifications
You must be signed in to change notification settings - Fork 434
feat: add processCredentialTimeout option to token command #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This update introduces a new flag `--process-credential-timeout` to the token command, allowing users to specify a timeout for the AWS credential_process execution. The timeout value can be set to a positive duration, overriding the SDK's default of 1 minute. The change includes updates to the `GetTokenOptions` struct and the associated binding in the command initialization.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: atishpatel The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @atishpatel! |
Hi @atishpatel. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This update introduces a new flag
--process-credential-timeout
to the token command, allowing users to specify a timeout for the AWS credential_process execution. The timeout value can be set to a positive duration, overriding the SDK's default of 1 minute. The change includes updates to theGetTokenOptions
struct and the associated binding in the command initialization.What this PR does / why we need it:
--process-credential-timeout
flag to thetoken
command to control the AWScredential_process
timeout.GetTokenOptions.ProcessCredentialTimeout
and applies it viaconfig.WithProcessCredentialOptions
to setprocesscreds.Options.Timeout
.0
, the SDK’s default (1 minute) is used.Implementation highlights:
pkg/token/token.go
: addedProcessCredentialTimeout time.Duration
toGetTokenOptions
; set timeout inLoadDefaultConfig
when > 0.cmd/aws-iam-authenticator/token.go
: added--process-credential-timeout
flag (Duration), bound with viper, and passed toGetTokenOptions
.Testing:
Testing Proof
Without Flag
With Flag
Release note:
--process-credential-timeout
toaws-iam-authenticator token
to override the default 1-minute AWS credential_process timeout.