Skip to content

Conversation

atishpatel
Copy link

@atishpatel atishpatel commented Oct 7, 2025

This update introduces a new flag --process-credential-timeout to the token command, allowing users to specify a timeout for the AWS credential_process execution. The timeout value can be set to a positive duration, overriding the SDK's default of 1 minute. The change includes updates to the GetTokenOptions struct and the associated binding in the command initialization.

What this PR does / why we need it:

  • Adds an optional --process-credential-timeout flag to the token command to control the AWS credential_process timeout.
  • Plumbs the flag through GetTokenOptions.ProcessCredentialTimeout and applies it via config.WithProcessCredentialOptions to set processcreds.Options.Timeout.
  • Default behavior is unchanged: if the flag is omitted or set to 0, the SDK’s default (1 minute) is used.
  • Needed for environments where dual-control approval flows routinely exceed 60s; reduces spurious “credential process timed out” failures.

Implementation highlights:

  • pkg/token/token.go: added ProcessCredentialTimeout time.Duration to GetTokenOptions; set timeout in LoadDefaultConfig when > 0.
  • cmd/aws-iam-authenticator/token.go: added --process-credential-timeout flag (Duration), bound with viper, and passed to GetTokenOptions.
  • No server-side changes; purely client-side and backward-compatible.

Testing:

  • I verified no timeout at 60s with flag.
  • Omit the flag to confirm behavior remains unchanged.

Testing Proof
Without Flag

❯ WS_PROFILE=xyz--cluster-admin ./_output/bin/aws-iam-authenticator_v0.7.8_darwin_arm64 token --cluster-id prod-green --cache --log-verbosity error
This AWS role has dual-control enabled. To continue, please have someone approve your AWS access request before it expires:

https://.../v1/...?defer=yes

State      Expires in   Refresh in
pending    29m1s        2s          
could not get token: operation error STS: GetCallerIdentity, get identity: get credentials: failed to refresh cached credentials, process provider error: credential process timed out: signal: killed

With Flag

❯ AWS_PROFILE=xyz--cluster-admin ./_output/bin/aws-iam-authenticator_v0.7.8_darwin_arm64 token --cluster-id prod-green --cache --log-verbosity error --process-credential-timeout="5m"
This AWS role has dual-control enabled. To continue, please have someone approve your AWS access request before it expires:

https://.../v1/...?defer=yes

State      Expires in   Refresh in
pending    27m56s       3s
// does not exit after 1 minute

Release note:

  • Add --process-credential-timeout to aws-iam-authenticator token to override the default 1-minute AWS credential_process timeout.

This update introduces a new flag `--process-credential-timeout` to the token command, allowing users to specify a timeout for the AWS credential_process execution. The timeout value can be set to a positive duration, overriding the SDK's default of 1 minute. The change includes updates to the `GetTokenOptions` struct and the associated binding in the command initialization.
Copy link

linux-foundation-easycla bot commented Oct 7, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: atishpatel / name: Atish Patel (40c5027)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atishpatel
Once this PR has been reviewed and has the lgtm label, please assign haoranleo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 7, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @atishpatel!

It looks like this is your first PR to kubernetes-sigs/aws-iam-authenticator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-iam-authenticator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 7, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @atishpatel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants