-
Notifications
You must be signed in to change notification settings - Fork 449
Add ability to disable creation of dns zone for unmanaged installs #5666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @sadasu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5666 +/- ##
==========================================
+ Coverage 52.83% 52.95% +0.11%
==========================================
Files 278 279 +1
Lines 29610 29634 +24
==========================================
+ Hits 15645 15692 +47
+ Misses 13148 13123 -25
- Partials 817 819 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4c7fe79
to
1ed0e07
Compare
/ok-to-test |
/retest @sadasu Can you please run |
7ce774b
to
b660d6d
Compare
/retest |
b660d6d
to
58dae51
Compare
@willie-yao could you please take another look? Thanks! |
LGTM, I don't have anything to add here. |
6f2bf33
to
153fae0
Compare
Similar to managed installs, add ability to optionally create DNS zones for unmanged installs.
153fae0
to
14ce92f
Compare
@@ -1251,3 +1251,11 @@ func (s *ClusterScope) getLastAppliedSecurityRules(nsgName string) map[string]in | |||
} | |||
return lastAppliedSecurityRules | |||
} | |||
|
|||
// PrivateDNSZoneMode returns the cluster resource group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this comment is correct
Similar to managed installs, add ability to optionally create DNS zones for unmanged installs.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds the ability to optionally create private DNS zones for unmanaged clusters. Without this feature they are always created. There are some instances we would like to use a DNS service other than Azure DNS and would like CAPI to withhold creation of private DNS Zones at those times. This feature adds a new field to NetworkSpec that allows us to skip creation of the DNS zone. Default behavior remains unchanged where DNS zones are created during cluster creation.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: