Update kubelet restart script in Windows templates #5967
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5967 +/- ##
=======================================
Coverage 44.54% 44.54%
=======================================
Files 279 279
Lines 25140 25140
=======================================
Hits 11199 11199
Misses 13128 13128
Partials 813 813 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/cherry-pick release-1.21 |
|
@mboersma: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test ? |
|
@nojnhuh: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Looking through the test configs, I don't see any of our presubmits that invoke ci-entrypoint with /hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 41e9612aae1d53dc281848eeeeb88b10c80860f1
|
k8s-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marosset, nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In my testing I'm seeing the Windows Nodes come up, but then cloud-node-manager is skipping them so they don't get a providerID which CAPI expects. I can see in https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/directory/pull-azurefile-csi-driver-e2e-capz-windows-2022-hostprocess/1986347754665807872 that the kubelet failed right after it started up but the logs are empty in the artifacts. The template is still setting the From scm.log: |
Maybe there's some contention between the two service launchers? |
|
/cc @zylxjtu |
|
These are the kubelet logs I've gathered from a Node in my local testing: https://gist.github.com/nojnhuh/465e48aeee5be0bdde8c7bf070803ad6 @marosset @zylxjtu Do you spot any meaningful errors there? There are quite a few messages about CNI not being ready, but I wonder if those are expected while everything is starting up. All pods are reporting Running and Ready. |
|
For context, in my testing I'm trying to mimic this job: https://testgrid.k8s.io/provider-azure-azurefile-csi-driver#pull-azurefile-csi-driver-e2e-capz-windows-2022-hostprocess
|
I'm running into the same issue trying to fix this in testgrid. We're waiting on the MachineDeployment which stays |
|
/test pull-cluster-api-provider-azure-e2e |
|
@mboersma: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates commands in Windows templates to work with either old nssm.exe or new sc.exe for running the kubelet.exe service.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
TODOs:
Release note: