Skip to content

📖 Update API conventions #12581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

📖 Update API conventions #12581

merged 1 commit into from
Aug 22, 2025
+8 −49

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Aug 5, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 5, 2025
@sbueringer
Copy link
Member Author

sbueringer commented Aug 5, 2025 •
edited
Loading

/assign @fabriziopandini @JoelSpeed

/hold
Would be good if @fabriziopandini takes a look as well before this PR is merged once he's back

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2025
@sbueringer sbueringer added the area/documentation Issues or PRs related to documentation label Aug 5, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Aug 5, 2025
@sbueringer sbueringer force-pushed the pr-update-api-conventions branch from b979c6f to 94fca58 Compare August 5, 2025 10:03
@sbueringer sbueringer mentioned this pull request Aug 4, 2025
Open
84 tasks
@JoelSpeed
Copy link
Contributor

/lgtm

Will defer to @fabriziopandini for approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e5126d737533aac83f34219de04ec6d5bfaa45da

mboersma
mboersma approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

fabriziopandini
fabriziopandini reviewed Aug 21, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Only one small improvement if that's of for you

@sbueringer
Update API conventions
5b06a59 
Signed-off-by: Stefan Büringer [email protected]
@sbueringer sbueringer force-pushed the pr-update-api-conventions branch from 94fca58 to 5b06a59 Compare August 21, 2025 17:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2025
fabriziopandini
fabriziopandini reviewed Aug 22, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 14dc031094d35eec844e4835eb3ad3ae650963c0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2025
@fabriziopandini
Copy link
Member

/cherry-pick release-1.11

@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fabriziopandini
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5857f3f into kubernetes-sigs:main Aug 22, 2025
16 of 17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Aug 22, 2025
@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: new pull request created: #12671

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 22, 2025
Merged
@sbueringer sbueringer deleted the pr-update-api-conventions branch August 22, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@chrischdi chrischdi Awaiting requested review from chrischdi

@richardcase richardcase Awaiting requested review from richardcase

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@mboersma mboersma Awaiting requested review from mboersma

Assignees

@mboersma mboersma

@fabriziopandini fabriziopandini

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.
6 participants
@sbueringer @JoelSpeed @k8s-ci-robot @fabriziopandini @k8s-infra-cherrypick-robot @mboersma