✨ Cleanup exp packages

[sbueringer]

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
As discussed a few times, we want to cleanup our exp packages. This PR moves MachinePool, ExtensionConfig and IPAM webhooks/controllers into their correct packages

(There are no plans to backport this into release-1.11)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[sbueringer]

/assign @JoelSpeed @chrischdi @fabriziopandini @mboersma @richardcase @sivchari @jackfrancis

[sbueringer]

/test pull-cluster-api-e2e-main

[k8s-ci-robot]

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-apidiff-main	35b28c4	link	false	/test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[richardcase]

Looks good to me @sbueringer.

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: c31ad7f4d756e396f7309e5e94de9622fa2b31ac

[sivchari]

Thx!
/lgtm

[jackfrancis]

Congrats on reducing the CAPI maintenance burden @sbueringer and to @mboersma @willie-yao @richardcase for your work over several years stabilizing MachinePools in preparation for this!

/lgtm

[fabriziopandini]

Happy to see another cleanup to the code structure, thanks!

I assume we will get rid of the /exp package under test/infrastructure/docker in a follow up PR, is that right?

[fabriziopandini]

Wondering if we should align index management for extension config to what we are doing for other indexes, and move this file + the corresponding test to api/core/v1beta2/index

[sbueringer]

I think I wouldn't export that index and make it part of our API. I'm also not sure who would be consuming that.

Additionally the index is a purely client-side thing anyway so everyone can implement the same or a different index on their side if they want to.

For us this index only makes sense because we inject the caBundle. I'm not aware of use cases for anyone else to be honest

[fabriziopandini]

As discussed, we should move indexes out of the API package, ideally somewhere internal (unless it is required for using some public util func), and then move also the ExtensionConfig index in the target location once it is defined

Considering this, it is ok the keep ExtensionConfig indexes where they are for this PR

[sbueringer]

I assume we will get rid of the /exp package under test/infrastructure/docker in a follow up PR, is that right?

In general, we should yes. But I think the effort is higher and the benefit much lower (we barely touch any of that code)

[fabriziopandini]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

Congrats on reducing the CAPI maintenance burden @sbueringer and to @mboersma @willie-yao @richardcase for your work over several years stabilizing MachinePools in preparation for this!

Just to clarify, this was only a code cleanup as we wanted to get rid of exp packages independent of feature state. This is not a sign of graduation of MachinePools. That is tracked and discussed here #9005, and frankly, it is not looking good.

[richardcase]

That is tracked and discussed here #9005, and frankly, it is not looking good.

There has been a small amount of progress, need to do more and get more help.