Skip to content

Conversation

zhengkezhou1
Copy link
Contributor

Fix #325

Add test cases for:

  • handling unavailable backend pods
  • invalid model requests

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 26, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and robscott June 26, 2025 14:10
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 26, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @zhengkezhou1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 26, 2025
Copy link

netlify bot commented Jun 26, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit be00d8b
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/685d54e59d9bbb0008e3770f
😎 Deploy Preview https://deploy-preview-1074--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ahg-g
Copy link
Contributor

ahg-g commented Jun 26, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2025
@zhengkezhou1
Copy link
Contributor Author

@liu-cong can your please take a look?

@kfswain
Copy link
Collaborator

kfswain commented Jul 31, 2025

/lgtm
/approve

Looks great! Thanks!

Quick question; why the giraffe hate? 😆
image

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain, zhengkezhou1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit 37b43b6 into kubernetes-sigs:main Jul 31, 2025
9 checks passed
@zhengkezhou1
Copy link
Contributor Author

/lgtm /approve

Looks great! Thanks!

Quick question; why the giraffe hate? 😆 image

Its Meme: https://www.reddit.com/r/funny/comments/qog3f/giraffes_are_heartless_creatures/?utm_source=share&utm_medium=mweb3x&utm_name=mweb3xcss&utm_term=1&utm_content=share_button

@kfswain
Copy link
Collaborator

kfswain commented Jul 31, 2025

hahaha I love it

kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration tests on error cases
4 participants