Skip to content

feat: improve logging for plugin selection and scoring #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Jul 17, 2025

Fixes: #1170

Copy link

netlify bot commented Jul 17, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 34a8868
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6878ea13191f2900089476a1
😎 Deploy Preview https://deploy-preview-1178--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Xunzhuo
Once this PR has been reviewed and has the lgtm label, please assign danehans for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 17, 2025
Signed-off-by: bitliu <[email protected]>
@nirrozenbaum nirrozenbaum self-assigned this Jul 18, 2025
@nirrozenbaum
Copy link
Contributor

@Xunzhuo thanks for this PR.
I was thinking about using String() function to return a descriptive string (maybe in json format or something like that), and then being able to log it using just name-value pairs.

current approach lacks the contextual logging (we don't use log.FromContext(ctx)), which might be helpful in some cases.

wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logging for plugin selection and scoring in GIE
3 participants