moved build details to version package #1185
Conversation
Signed-off-by: Nir Rozenbaum <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
approved
| @@ -197,6 +198,8 @@ func (r *Runner) Run(ctx context.Context) error { | |||
| flag.Parse() | |||
| initLogging(&opts) | |||
|
|
|||
| setupLog.Info("GIE build", "commit-sha", version.CommitSHA, "build-ref", version.BuildRef) | |||
There was a problem hiding this comment.
Can we set log levels on the setup log? If so, this feels like a Debug level log
There was a problem hiding this comment.
don’t you want to always know the details of the image we’re running? last commit sha? currently when seeing the log we have no way to know what version of GIE was used.
This is a common practice, also in kubernetes.. for example:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kube-scheduler/app/server.go#L174
|
/approve One small comment, will leave to Jeff to give LGTM stamp |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This PR moves build versions/details into a version dedicated package, instead of having the build details in metrics package, which seems non-related.
cc @JeffLuoo @kfswain