Skip to content

fix(cleanup) added pointer usage for failure mode #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+13 −6
Closed

fix(cleanup) added pointer usage for failure mode #1428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14763aa
added pointer usage for failure mode
capri-xiyue Aug 21, 2025
85419bf
fixed ut
capri-xiyue Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion api/v1/inferencepool_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,8 @@ type EndpointPickerRef struct {
//
// +optional
// +kubebuilder:default="FailClose"
FailureMode ExtensionFailureMode `json:"failureMode,omitempty"`
//nolint:kubeapilinter // ignore kubeapilinter here as we want to use pointer here for optional struct.
FailureMode *ExtensionFailureMode `json:"failureMode,omitempty"`
}

// ExtensionFailureMode defines the options for how the gateway handles the case when the extension is not
Expand Down
5 changes: 5 additions & 0 deletions api/v1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions apix/v1alpha2/inferencepool_conversion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ func convertExtensionRefToV1(src *Extension) (v1.EndpointPickerRef, error) {
endpointPickerRef.PortNumber = &v1PortNumber
}
if src.FailureMode != nil {
endpointPickerRef.FailureMode = v1.ExtensionFailureMode(*src.FailureMode)
v1FailureMode := v1.ExtensionFailureMode(*src.FailureMode)
endpointPickerRef.FailureMode = &v1FailureMode
}

return endpointPickerRef, nil
Expand All @@ -144,8 +145,8 @@ func convertEndpointPickerRefFromV1(src *v1.EndpointPickerRef) (Extension, error
portNumber := PortNumber(*src.PortNumber)
extension.PortNumber = &portNumber
}
if src.FailureMode != "" {
extensionFailureMode := ExtensionFailureMode(src.FailureMode)
if src.FailureMode != nil {
extensionFailureMode := ExtensionFailureMode(*src.FailureMode)
extension.FailureMode = &extensionFailureMode
}
return extension, nil
Expand Down
4 changes: 2 additions & 2 deletions apix/v1alpha2/inferencepool_conversion_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ func TestInferencePoolConvertTo(t *testing.T) {
Kind: v1Kind,
Name: "my-epp-service",
PortNumber: &v1PortNumber,
FailureMode: v1FailureMode,
FailureMode: &v1FailureMode,
},
},
Status: v1.InferencePoolStatus{
Expand Down Expand Up @@ -240,7 +240,7 @@ func TestInferencePoolConvertFrom(t *testing.T) {
Kind: v1Kind,
Name: "my-epp-service",
PortNumber: &v1PortNumber,
FailureMode: v1FailureMode,
FailureMode: &v1FailureMode,
},
},
Status: v1.InferencePoolStatus{
Expand Down