fork daneyon's change - Refactors InferencePool v1 Status and FailureModes #1438
+426
−319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiyue Yu <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
size/XL
capri-xiyue
changed the title
|
assign @kfswain |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: capri-xiyue, kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
closed as #1441 uses the correct fork approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind
What this PR does / why we need it:
Refactors InferencePool v1 status.
Expands godocs for InferencePool v1 status.
Makes the Namespace and Kind fields of a ParentRef optional to match Gateway API ref semantics.
Adds the correct typeMeta version in InferencePool v1 <> v1alpha2 conversion.
Commit 77831c7 renames the FailureMode types from ExtensionXX to EndpointPickerXXX.
Commit 4abcaab aligns v1 InferencePool API types with K8s built-in API and Gateway API conventions, e.g., optional fields are pointer types.
Commit 88990b0 runs the API docs generators.
This is a fork of #1427, I just made it pass the linter
Which issue(s) this PR fixes:
Fixes #
Supports: #1173
Does this PR introduce a user-facing change?: