🌱 Add unit tests for alpha/internal/update #4931

cmallikarjunah · 2025-07-16T08:44:12Z

Issue: 4925

Added unit tests for the following alpha internal update files:

pkg/cli/alpha/internal/update/prepare_test.go
pkg/cli/alpha/internal/update/update_test.go
pkg/cli/alpha/internal/update/validate_test.go
pkg/cli/alpha/internal/update/utils_test.go

linux-foundation-easycla · 2025-07-16T08:44:17Z

The committers listed above are authorized under a signed CLA.

✅ login: cmallikarjunah (15b7a1b)

k8s-ci-robot · 2025-07-16T08:44:21Z

Welcome @cmallikarjunah!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-07-16T08:44:22Z

Hi @cmallikarjunah. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pkg/cli/alpha/command_test.go

camilamacedo86 · 2025-07-20T23:29:25Z

pkg/cli/alpha/internal/update/prepare.go

@@ -75,7 +75,7 @@ func (opts *Update) defineFromVersion(config store.Store) (string, error) {

 func (opts *Update) defineToVersion() string {
 	if len(opts.ToVersion) != 0 {
-		if !strings.HasPrefix(opts.FromVersion, "v") {
+		if !strings.HasPrefix(opts.ToVersion, "v") {


Could you please rebase with master?
So that we have no this change it is fixed and merged now 👍

Sure Camila, will do

@camilamacedo86 I have rebased. But the code in master still checks prefix for opts.FromVersion in function defineToVersion(). Can you re-check and confirm if this change is not needed?

pkg/cli/alpha/internal/update/prepare_test.go

pkg/cli/alpha/command_test.go

pkg/cli/alpha/internal/update/prepare_test.go

pkg/cli/alpha/internal/update/update_test.go

pkg/cli/alpha/internal/update/prepare_test.go

camilamacedo86

Great work 🥇
To be fixed, for we can merge, I thinkit is only this one: https://github.com/kubernetes-sigs/kubebuilder/pull/4931/files#r2233127738

However, I think we need to find a better way to create those temporary directories.
However, it is for a follow-up. No worry, see: https://github.com/kubernetes-sigs/kubebuilder/pull/4931/files#r2233130602.

pkg/cli/alpha/internal/update/prepare_test.go

Add pkg/cli/alpha/internal/update/prepare_test.go Add pkg/cli/alpha/internal/update/update_test.go Add pkg/cli/alpha/internal/update/validate_test.go Add pkg/cli/alpha/internal/update/utils_test.go

camilamacedo86

/lgtm
/ok-to-test

Great work 🚀
Well done !!!

Thank you for the contribution 🥇

k8s-ci-robot · 2025-07-29T12:53:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, cmallikarjunah, mayuka-c

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 16, 2025

k8s-ci-robot requested review from rashmigottipati and varshaprasad96 July 16, 2025 08:44

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 16, 2025

cmallikarjunah changed the title ~~🌱(cli; alpha commands): Add unit tests for alpha commands~~ 🌱WiP (cli; alpha commands): Add unit tests for alpha commands Jul 16, 2025

cmallikarjunah changed the title ~~🌱WiP (cli; alpha commands): Add unit tests for alpha commands~~ [WiP] 🌱 (cli; alpha commands): Add unit tests for alpha commands Jul 16, 2025

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 16, 2025

cmallikarjunah mentioned this pull request Jul 16, 2025

[Help Wanted] - Increase the coverage of unit tests #4925

Open

camilamacedo86 reviewed Jul 16, 2025

View reviewed changes

pkg/cli/alpha/command_test.go Outdated Show resolved Hide resolved

cmallikarjunah force-pushed the issue-4925-add-UTs branch from 7c5b2d9 to c072261 Compare July 18, 2025 08:36

cmallikarjunah changed the title ~~[WiP] 🌱 (cli; alpha commands): Add unit tests for alpha commands~~ 🌱 (cli; alpha commands): Add unit tests for alpha commands Jul 18, 2025

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2025

cmallikarjunah changed the title ~~🌱 (cli; alpha commands): Add unit tests for alpha commands~~ 🌱 (cli; alpha commands): Add unit tests for alpha commands [WiP] Jul 20, 2025

camilamacedo86 reviewed Jul 20, 2025

View reviewed changes

pkg/cli/alpha/internal/update/prepare_test.go Show resolved Hide resolved

camilamacedo86 reviewed Jul 22, 2025

View reviewed changes

pkg/cli/alpha/command_test.go Outdated Show resolved Hide resolved

cmallikarjunah force-pushed the issue-4925-add-UTs branch 4 times, most recently from 734cfa4 to 9612be0 Compare July 23, 2025 18:47

cmallikarjunah changed the title ~~🌱 (cli; alpha commands): Add unit tests for alpha commands [WiP]~~ [WiP]:seedling: (cli; alpha commands): Add unit tests for alpha commands Jul 24, 2025

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2025

cmallikarjunah force-pushed the issue-4925-add-UTs branch 2 times, most recently from e83c126 to 6b552e5 Compare July 25, 2025 12:52

camilamacedo86 reviewed Jul 25, 2025

View reviewed changes

pkg/cli/alpha/internal/update/prepare_test.go Outdated Show resolved Hide resolved