🐛 fix(CLI/test): Preserve namespaced scope on edit - #5756
Conversation
When running `edit --multigroup` or `edit --license`, the scaffold should not inadvertently clear the namespaced scope. This change adds tests to ensure that the `namespaced` setting in the project configuration is preserved when these flags are used, and that the RBAC Role is not overwritten with a ClusterRole.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: afzal442 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
| }) | ||
| }) | ||
|
|
||
| // PreScaffold -> Scaffold |
There was a problem hiding this comment.
We have only tests here
So, the bug does not occur?
There was a problem hiding this comment.
Could you plz elaborate on that?
There was a problem hiding this comment.
The title describe that the changes here fix a bug.
However you ONLY added new tests, so how the bug is fixed?
Have we not the bug?
3 participants
When running
edit --multigrouporedit --license, the scaffold should not inadvertently clear the namespaced scope.This change adds tests to ensure that the
namespacedsetting in the project configuration is preserved when these flags are used, and that the RBAC Role is not overwritten with a ClusterRole.Fixes: #5752