-
Couldn't load subscription status.
- Fork 157
chore: Bump kind to v0.30.0 #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/test pull-prow-integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems unrelated, is there a reason we need to do this due to the kind bump?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @smg247, thanks for reviewing the PR.
This change was done to reduce the flakey nature of TestRerun in the integration test suite.
On observing the associated logs, the rerun() call, when invoked subsequently was mostly a hit or miss. Providing sufficient time before rerun allowed the test case to pass successfully even run in loops. The cue was taken from the preceeding code, and the associated log line - Response body: Job successfully triggered. Wait 30 seconds and refresh the page for the job to show up..
Similar examples:
1971657033849507840
1971657033849507840
1967608691955863552
and so on..
Allowing some time seems to have reduced the chance of failure, please let me know your thoughts on this
Thanks!
|
It probably would be better to have the test improvement be a separate change than the kind bump. But that said, it's a small enough change, and looks OK to me. /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishen-v, matthyx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR enables bumping of kind to the latest available versions.