Skip to content

Conversation

@kishen-v
Copy link
Contributor

This PR enables bumping of kind to the latest available versions.

@netlify
Copy link

netlify bot commented Sep 15, 2025

Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit d8f9cbc
🔍 Latest deploy log https://app.netlify.com/projects/k8s-prow/deploys/68d20bb3075654000896f8aa
😎 Deploy Preview https://deploy-preview-518--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 15, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 15, 2025
@kishen-v
Copy link
Contributor Author

/test pull-prow-integration

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems unrelated, is there a reason we need to do this due to the kind bump?

Copy link
Contributor Author

@kishen-v kishen-v Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @smg247, thanks for reviewing the PR.
This change was done to reduce the flakey nature of TestRerun in the integration test suite.

On observing the associated logs, the rerun() call, when invoked subsequently was mostly a hit or miss. Providing sufficient time before rerun allowed the test case to pass successfully even run in loops. The cue was taken from the preceeding code, and the associated log line - Response body: Job successfully triggered. Wait 30 seconds and refresh the page for the job to show up..

Similar examples:
1971657033849507840
1971657033849507840
1967608691955863552
and so on..

Allowing some time seems to have reduced the chance of failure, please let me know your thoughts on this

Thanks!

@stmcginnis
Copy link
Contributor

It probably would be better to have the test improvement be a separate change than the kind bump. But that said, it's a small enough change, and looks OK to me.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2025
@matthyx
Copy link
Contributor

matthyx commented Oct 25, 2025

/approve
thanks @kishen-v and @stmcginnis

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishen-v, matthyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit bffdbcf into kubernetes-sigs:main Oct 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants