Remove exit after scale-up is performed #8313
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Static Autoscaler has been exiting
RunOnce
method early in case of scale-up, either successful or unsuccessful. This made scale-down not run in loops were scaling up was attempted.This can cause issues with persistently failing scale-ups blocking scale-down in the cluster. I don't believe there are any reasons why we would need to keep this early-exit logic.
Special notes for your reviewer:
Please advice if you have any intuition on what could potentially break after this change. I believe the snapshot logic should be able to maintain consistent cluster state after attempting scale-up, so I don't see a reason why scale-down could fail after that.
Does this PR introduce a user-facing change?