Skip to content

Remove exit after scale-up is performed #8313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BigDarkClown
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Static Autoscaler has been exiting RunOnce method early in case of scale-up, either successful or unsuccessful. This made scale-down not run in loops were scaling up was attempted.

This can cause issues with persistently failing scale-ups blocking scale-down in the cluster. I don't believe there are any reasons why we would need to keep this early-exit logic.

Special notes for your reviewer:

Please advice if you have any intuition on what could potentially break after this change. I believe the snapshot logic should be able to maintain consistent cluster state after attempting scale-up, so I don't see a reason why scale-down could fail after that.

Does this PR introduce a user-facing change?

Remove early-exit from control loop after scale-up attempt, enabling scale-up and scale-down to be performed in a single loop

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area labels Jul 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BigDarkClown

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler and removed do-not-merge/needs-area labels Jul 10, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants