Fix bash-based word count validation for steering elections #8602
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
sig/contributor-experience
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
There was a problem hiding this comment.
Let's get this version in for now to unblock the bios, then get #8596 in at a later time!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, npolshakova The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| export KUBE_ROOT=$(dirname "${BASH_SOURCE}")/.. | ||
|
|
||
| # exclude bios before 2025 since some of them have more than 300 words | ||
| STEERING_ELECTION_BIOS="${KUBE_ROOT}/elections/steering/!(2017|2018|2019|2020|2021|2022|2023|2024)/candidate-*.md" |
There was a problem hiding this comment.
/lgtm
But would it be better to glob the year directory too so folks don't need to remember to update each time.
There was a problem hiding this comment.
I see the expectation is for the Go version to validate 2025 and later, so please ignore my last comment. ;)
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This was broken because it was pointing to the wrong directory. I've got a better go-based version in #8596, but this at least fixes the bash version immediately