Skip to content

[KEP-4639] Graduate image volumes to GA #5450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[KEP-4639] Graduate image volumes to GA #5450

wants to merge 1 commit into from
+23 −16

Conversation

saschagrunert
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 15, 2025
@k8s-ci-robot k8s-ci-robot requested a review from dchen1107 July 15, 2025 08:14
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jul 15, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mrunalp July 15, 2025 08:14
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jul 15, 2025
@saschagrunert saschagrunert added this to the v1.35 milestone Jul 15, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 15, 2025
saschagrunert
saschagrunert commented Jul 15, 2025
View reviewed changes
@saschagrunert saschagrunert mentioned this pull request Jul 15, 2025
Open
14 tasks
@gbartolini gbartolini mentioned this pull request Jul 17, 2025
Closed
2 tasks
@SergeyKanzhelev
Copy link
Member

So readonlysupport will be a separate KEP?

@saschagrunert
Copy link
Member Author

So readonlysupport will be a separate KEP?

Read write support will be a separate KEP, yes.

@Barakmor1 Barakmor1 mentioned this pull request Jul 24, 2025
Open
1 task
@Barakmor1 Barakmor1 mentioned this pull request Aug 7, 2025
Open
@hakman hakman mentioned this pull request Aug 8, 2025
Merged
@macsko
Copy link
Member

macsko commented Aug 25, 2025 •
edited
Loading

I see we have a PR opened for kube-scheduler (kubernetes/kubernetes#130231) that changes the scoring based on this feature. However, I don't see it mentioned in the KEP.

Is that change expected? If yes, it should be in this KEP.

@willswire willswire mentioned this pull request Aug 25, 2025
Open
@saschagrunert
Copy link
Member Author

I see we have a PR opened for kube-scheduler (kubernetes/kubernetes#130231) that changes the scoring based on this feature. However, I don't see it mentioned in the KEP.

Is that change expected? If yes, it should be in this KEP.

I don't think we should put that in scope of this KEP, but I don't see why other features should not rely on it once GA.

@saschagrunert
Copy link
Member Author

@kubernetes/sig-node-proposals PTAL

@k8s-ci-robot k8s-ci-robot added the kind/design Categorizes issue or PR as related to design. label Sep 3, 2025
@saschagrunert
Copy link
Member Author

cc @mikebrow

SergeyKanzhelev
SergeyKanzhelev reviewed Sep 3, 2025
View reviewed changes
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saschagrunert
Once this PR has been reviewed and has the lgtm label, please assign dchen1107, jpbetz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

SergeyKanzhelev
SergeyKanzhelev reviewed Sep 4, 2025
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, re-reading the whole KEP some notes:

  1. Non-goals still mention "alpha":

    That could be delegated to the consumer or perhaps to some hooks and is out of scope for alpha.

  2. Testing section needs to be updated for containerd:

    When containerd adds support for the feature, then the e2e tests will become available for that runtime as well.

  3. As part of implementation, let's get rid of a separate test lane (https://testgrid.k8s.io/sig-node-cri-o#pr-crio-cgrpv2-imagevolume-e2e) for the feature and mark it as NodeConformance. The feature doesn't have any special node configurations needed. Also remove the Feature tag. It may be too late to replace with FeatureGate since it was GA'd. Maybe for the case of emulated version testing only.

keps/sig-node/4639-oci-volume-source/README.md
@@ -881,8 +884,6 @@ in back-to-back releases.
- Multiple examples of real world uses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GA criteria typically has a requirement to imlpement a Conformance test. Can we include it please. It was a recent contention point with DRA and we need to follow the best practices here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the test graduation to conformance.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean real conformance, not only node conformance.

Conformance tests should cover all APIs. In this case we may have a simple conformance test that will create image-backed volume and produces it's content as an output.

keps/sig-node/4639-oci-volume-source/README.md
@@ -781,6 +782,8 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
- [sig-node] ImageVolume [NodeFeature:ImageVolume] should succeed with multiple pods and same image on the same node
- [sig-node] ImageVolume [NodeFeature:ImageVolume] should succeed with pod and multiple volumes
- [sig-node] ImageVolume [NodeFeature:ImageVolume] should succeed with pod and pull policy of Always
- [sig-node] ImageVolume [NodeFeature:ImageVolume] subPath should succeed when using a valid subPath
- [sig-node] ImageVolume [NodeFeature:ImageVolume] subPath should fail if subPath in volume is not existing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beside the first "should fail" test, is there any tests needed for crashloop backoff?

@saschagrunert
Graduate image volumes to GA
1a4174f 
Signed-off-by: Sascha Grunert <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2025
@saschagrunert
Copy link
Member Author

I updated the KEP. I also see that containerd/containerd#11578 is not being backported to containerd 2.1 yet. Is this a blocker @mikebrow ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@mrunalp mrunalp Awaiting requested review from mrunalp

+1 more reviewer

@mikebrow mikebrow mikebrow left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/design Categorizes issue or PR as related to design. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.35
Development

Successfully merging this pull request may close these issues.
5 participants
@saschagrunert @SergeyKanzhelev @macsko @k8s-ci-robot @mikebrow