Skip to content

Conversation

xirehat
Copy link

@xirehat xirehat commented Jul 14, 2025

I created this PR in advance, and in the coming hours I will create a PR for the Persian language of the Kubernetes website. I will inform you below (I opened it because one of the prerequisites of that PR is for localization).

Related PRs:
kubernetes/website#51801
kubernetes/website#51887
kubernetes/website#51929
kubernetes/website#51934

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xirehat
Once this PR has been reviewed and has the lgtm label, please assign onlydole for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 14, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @xirehat!

It looks like this is your first PR to kubernetes/org 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/org has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 14, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @xirehat. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 14, 2025
@cblecker
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2025
@xirehat
Copy link
Author

xirehat commented Aug 20, 2025

@cblecker It looks like the tests failed because we’re not members of the Kubernetes GitHub organization.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2025
@palnabarun
Copy link
Member

@xirehat Please work on raising requests to add yourselves to the Kubernetes GitHub org (https://github.com/kubernetes/community/blob/master/github-management/new-membership-procedure.md#membership-requirements)

/cc @divya-mohan0209 @natalisucks

@xirehat xirehat force-pushed the sig-docs-fa-members branch from 68d504d to ea45431 Compare August 28, 2025 13:17
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 28, 2025
@xirehat xirehat force-pushed the sig-docs-fa-members branch from ea45431 to 2b28ea6 Compare August 28, 2025 13:39
@k8s-ci-robot
Copy link
Contributor

@xirehat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-org-test-all 2b28ea6 link true /test pull-org-test-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@natalisucks
Copy link

natalisucks commented Aug 28, 2025

@xirehat As @palnabarun mentioned, you and the Persian team will need to make sure you're following the steps required to become org members for Kubernetes first. You will need two sponsors for each member, and given I've reviewed a lot of the Persian work happening for this localisation, i am happy to be one of those sponsors. Please use the #sig-docs channel on Slack to find other sponsors as needed and raise the required PRs per this guide, thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants