-
Notifications
You must be signed in to change notification settings - Fork 782
Add sig-docs-fa members #5701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add sig-docs-fa members #5701
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xirehat The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @xirehat! |
Hi @xirehat. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@cblecker It looks like the tests failed because we’re not members of the Kubernetes GitHub organization. |
@xirehat Please work on raising requests to add yourselves to the Kubernetes GitHub org (https://github.com/kubernetes/community/blob/master/github-management/new-membership-procedure.md#membership-requirements) |
68d504d
to
ea45431
Compare
ea45431
to
2b28ea6
Compare
@xirehat: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@xirehat As @palnabarun mentioned, you and the Persian team will need to make sure you're following the steps required to become org members for Kubernetes first. You will need two sponsors for each member, and given I've reviewed a lot of the Persian work happening for this localisation, i am happy to be one of those sponsors. Please use the #sig-docs channel on Slack to find other sponsors as needed and raise the required PRs per this guide, thanks 🙏 |
I created this PR in advance, and in the coming hours I will create a PR for the Persian language of the Kubernetes website. I will inform you below (I opened it because one of the prerequisites of that PR is for localization).
Related PRs:
kubernetes/website#51801
kubernetes/website#51887
kubernetes/website#51929
kubernetes/website#51934