Support storageProfile minimumSupportedPVCSize in clone #3852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
kubevirt-bot
added
the
do-not-merge/hold
arnongilboa
force-pushed
the
fix_clone_target_size_validation
branch
2 times, most recently
from
ab884cc to
1c9e46b
Compare
arnongilboa
force-pushed
the
fix_clone_target_size_validation
branch
4 times, most recently
from
3a3e45d to
6731ed0
Compare
alromeros
reviewed
Aug 5, 2025
| return storageResources, nil | ||
| } | ||
|
|
||
| if val, exists := storageProfile.Annotations[AnnMinimumSupportedPVCSize]; exists { |
There was a problem hiding this comment.
This logic is reimplemented in several places in the code, does it make sense to have a single helper and reuse it each time?
There was a problem hiding this comment.
Sure, fixing that. Thanks!
arnongilboa
force-pushed
the
fix_clone_target_size_validation
branch
from
6731ed0 to
d8e5528
Compare
|
/hold |
When the target DataVolume storage requests a size smaller than the source PVC. For target without size it already worked correctly. Signed-off-by: Arnon Gilboa <[email protected]>
arnongilboa
force-pushed
the
fix_clone_target_size_validation
branch
from
901cab0 to
df3cedc
Compare
|
/test pull-cdi-verify-go-mod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When the target
DataVolumestorage requests a size smaller than the source PVC. For target without size it already worked correctly.jira-ticket: https://issues.redhat.com/browse/CNV-64264
Release note: