fix(cli): fail sandbox create immediately with the server error - #180
Merged
Conversation
SSH signatures on sandbox POSTs were hashed over the JSON body, but the operator verifies an empty body. That 401ed create with no JSON. A later 503 (pool not ready) then waited nine minutes recovering a lease that never existed. Sign like lease_create, print error/detail at once, and put JSON on 401 extractor rejections. just install uses --locked.
cargo fmt --check on rust:1.94-bookworm groups axum::Json ahead of extract; local 1.95 rustfmt does not.
A 503 with a body is the server's last word. Recovering it as an in-flight CREATE sat for nine minutes. Keep settle/cleanup for ambiguous sends only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
kobe lease agent-trusted401ed with an empty body, then a later 503 sat for nine minutes polling a lease that was never created.Why
FromRequestPartscannot read it). Cluster create already signed empty.CREATE_SETTLE_TIMEOUT(9m).just installomitted--locked, so cargo re-resolved the lock.Changes
lease_create(empty body).error/detailimmediately; recover only if the POST itself may still be committing.detail.just installuses--locked.Operator image on int-pro does not need this for the current lease path: the CLI is already installed from this tree, and
agent-trustedis certified again.