Skip to content

Conversation

@werdes72
Copy link
Contributor

Description

Changes proposed in this pull request:

Pre-Merge Checklist

Consider all the following items. If your contribution violates any of them, or you are not sure about it, add a comment to the PR.

  • The code coverage is acceptable.
  • Release notes for the introduced changes are created.
  • If Kubebuilder changes were made, you ran make generate-manifests and committed the changes before the merge.
  • Pre-existing managed resources are correctly handled.
  • The change works on all hyperscalers supported by SAP BTP, Kyma runtime.
  • There is no upgrade downtime.
  • For infrastructure changes, you checked if the changes affect the hyperscaler's costs.
  • RBAC settings are as restrictive as possible.
  • If any new libraries are added, you verified license compliance and maintainability, and made a comment in the PR with details. We only allow stable releases to be included in the project.
  • You checked if this change should be cherry-picked to active release branches.
  • The configuration does not introduce any additional latency.

Related issues
#2101

@werdes72 werdes72 requested a review from a team as a code owner October 16, 2025 06:21
Copy link
Contributor

@kolodziejczak kolodziejczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to ensure that the existing resources get these labels as well. In the current state it seems to not to work. Please take a look on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants