fix(FR-3874): feed the staged value back into renderInput controls - #9502
Draft
nowgnuesLee wants to merge 1 commit into
Draft
fix(FR-3874): feed the staged value back into renderInput controls#9502nowgnuesLee wants to merge 1 commit into
nowgnuesLee wants to merge 1 commit into
Conversation
Since the Astryx PowerSearch rebuild a picked value is staged in
PowerSearch state and committed by the popover's Apply button. The
renderInput adapter received that staged value and the disabled state
from PowerSearch but forwarded only onChange, and every call site pinned
value={null} (the antd-era "clear after commit" convention). The select
therefore snapped back to its placeholder right after a pick, and editing
an existing token opened the select empty.
Forward value and isDisabled through FilterRenderInput, feed them back at
the five call sites, make FilterRenderInput the single home of the
stage/Apply contract prose, refresh the stories, and add an adapter test.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
PR Analysis Report📚 Storybook PreviewGitHub Pages may take up to a minute to hydrate after the deploy. 🧩 Changed Components
1 changed component(s) with no story to open
1 other changed file(s) in
|
| File | Size | Gzip | Δ Gzip vs base |
|---|---|---|---|
backend.ai-ui.js |
2068.8 kB | 505.0 kB | −0.0 kB |
Total gzip: 505.0 kB (−0.0 kB vs origin/main)
Contributor
Coverage Report for backend-ai-ui-coverage (./packages/backend.ai-ui)
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
Coverage Report for react-coverage (./react)
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9501 (FR-3874)
Symptom
A filter property that renders its own picker through
renderInput(project select on the admin session list, user select on RBAC and the user folder permission panel, storage host select on the model store and the admin model card) loses its selection visually:Cause
Since the Astryx
PowerSearchrebuild the picked value is staged in PowerSearch state and committed by the popover's Apply button.useRenderInputEditors(BAIPowerSearchAdapters.tsx) receives that stagedvalueandisDisabledfrom PowerSearch but forwarded onlyonChange, and every call site pinnedvalue={null}— the antd-era convention, where a pick committed immediately and the control had to clear itself.Change
FilterRenderInputnow receivesvalue: string | nullandisDisabled?: boolean; the cached editor passes them through. Serialization is untouched.renderInputcall sites feedvalue/isDisabledback into their select.FilterRenderInput; both filters'renderInputdocs point at it.toLabeledValuehelper maps the staged string toBAIComplexSelect's labeled value).BAIPowerSearchAdapters.test.tsxcovers the pass-through and the label recording.This is the
valueforwarding part of FR-3691 (#9089), split out so the visible defect can ship on its own. TheentitySourceredesign in #9089 is on hold (it drops the selects' scroll pagination).Verification
Live check against a local webserver (RBAC → 할당된 사용자): the picked email stays in the select with Apply enabled, the token reads the email while the URL carries the UUID, and re-opening the token shows the select pre-populated.
🤖 Generated with Claude Code