refactor: capture loop variables to avoid closure issues in goroutines across multiple files

Signed-off-by: cuisongliu <[email protected]>

Author: cuisongliu

lifecycle/cmd/sealos/cmd/exec.go

@@ -89,6 +89,7 @@ func runCommand(cluster *v2.Cluster, targets, args []string) error {
 	}
 	eg, _ := errgroup.WithContext(context.Background())
 	for _, ipAddr := range targets {
+		ipAddr := ipAddr
 		eg.Go(func() error {
 			return execer.CmdAsync(ipAddr, args...)
 		})

lifecycle/cmd/sealos/cmd/scp.go

@@ -73,6 +73,7 @@ func runCopy(cluster *v1beta1.Cluster, targets, args []string) error {
 	}
 	eg, _ := errgroup.WithContext(context.Background())
 	for _, ipAddr := range targets {
+		ipAddr := ipAddr
 		eg.Go(func() error {
 			return execer.Copy(ipAddr, args[0], args[1])
 		})

lifecycle/pkg/buildah/create.go

@@ -162,6 +162,7 @@ func runRender(mountPoints, env []string) error {
 	envs := maps.FromSlice(env)
 
 	for _, mountPoint := range mountPoints {
+		mountPoint := mountPoint
 		eg.Go(func() error {
 			if !file.IsExist(mountPoint) {
 				logger.Debug("MountPoint %s does not exist, skipping", mountPoint)

lifecycle/pkg/filesystem/rootfs/rootfs_default.go

@@ -58,6 +58,7 @@ func (f *defaultRootfs) mountRootfs(cluster *v2.Cluster, ipList []string) error
 	envProcessor := env.NewEnvProcessor(cluster)
 	// TODO: remove this when rendering on client side is GA
 	for _, mount := range f.mounts {
+		mount := mount
 		eg.Go(func() error {
 			if !file.IsExist(mount.MountPoint) {
 				logger.Debug("Image %s not exist, render env continue", mount.ImageName)
@@ -120,6 +121,7 @@ func (f *defaultRootfs) mountRootfs(cluster *v2.Cluster, ipList []string) error
 	rootfsEnvs := v2.MergeEnvWithBuiltinKeys(rootfs.Env, *rootfs)
 
 	for _, ip := range ipList {
+		ip := ip
 		eg.Go(func() error {
 			var renderingRequired bool
 			for i := range f.mounts {
@@ -191,6 +193,7 @@ func (f *defaultRootfs) unmountRootfs(cluster *v2.Cluster, ipList []string) erro
 	}
 
 	for _, ip := range ipList {
+		ip := ip
 		eg.Go(func() error {
 			return execer.CmdAsync(ip, rmRootfs, deleteHomeDirCmd)
 		})

lifecycle/pkg/runtime/k3s/bootstrap.go

@@ -268,6 +268,7 @@ func (k *K3s) copyKubeConfigFileToNodes(hosts ...string) error {
 	}
 	eg, _ := errgroup.WithContext(context.Background())
 	for _, node := range hosts {
+		node := node
 		eg.Go(func() error {
 			home, err := k.execer.CmdToString(node, "echo $HOME", "")
 			if err != nil {

lifecycle/pkg/runtime/k3s/k3s.go

@@ -135,6 +135,7 @@ func (k *K3s) SyncNodeIPVS(mastersIPList, nodeIPList []string) error {
 	image := k.cluster.GetLvscareImage()
 	eg, _ := errgroup.WithContext(context.Background())
 	for _, node := range nodeIPList {
+		node := node
 		eg.Go(func() error {
 			logger.Info("start to sync lvscare static pod to node: %s master: %+v", node, masters)
 			err := k.remoteUtil.StaticPod(

lifecycle/pkg/runtime/kubernetes/certs.go

@@ -192,6 +192,7 @@ func (k *KubeadmRuntime) deleteAPIServer() error {
 	logger.Info("delete pod apiserver from crictl")
 	eg, _ := errgroup.WithContext(context.Background())
 	for _, master := range k.getMasterIPAndPortList() {
+		master := master
 		eg.Go(func() error {
 			podIDJson, err := k.sshCmdToString(master, podIDSh)
 			if err != nil {

lifecycle/pkg/runtime/kubernetes/kubeconfig.go

@@ -29,6 +29,7 @@ func (k *KubeadmRuntime) copyKubeConfigFileToNodes(hosts ...string) error {
 	src := k.pathResolver.AdminFile()
 	eg, _ := errgroup.WithContext(context.Background())
 	for _, node := range hosts {
+		node := node
 		eg.Go(func() error {
 			home, err := k.execer.CmdToString(node, "echo $HOME", "")
 			if err != nil {

lifecycle/pkg/runtime/kubernetes/master.go

@@ -114,6 +114,7 @@ func (k *KubeadmRuntime) imagePull(hostAndPort, version string) error {
 func (k *KubeadmRuntime) sendJoinCPConfig(joinMaster []string) error {
 	eg, _ := errgroup.WithContext(context.Background())
 	for _, master := range joinMaster {
+		master := master
 		eg.Go(func() error {
 			k.mu.Lock()
 			defer k.mu.Unlock()
@@ -224,6 +225,7 @@ func (k *KubeadmRuntime) deleteMasters(masters []string) error {
 	}
 	eg, _ := errgroup.WithContext(context.Background())
 	for _, master := range masters {
+		master := master
 		eg.Go(func() error {
 			logger.Info("start to delete master %s", master)
 			if err := k.deleteMaster(master); err != nil {

lifecycle/pkg/runtime/kubernetes/node.go

@@ -41,6 +41,7 @@ func (k *KubeadmRuntime) joinNodes(newNodesIPList []string) error {
 	}
 	eg, _ := errgroup.WithContext(context.Background())
 	for _, node := range newNodesIPList {
+		node := node
 		eg.Go(func() error {
 			logger.Info("start to join %s as worker", node)
 			k.mu.Lock()
@@ -101,6 +102,7 @@ func (k *KubeadmRuntime) deleteNodes(nodes []string) error {
 	}
 	eg, _ := errgroup.WithContext(context.Background())
 	for _, node := range nodes {
+		node := node
 		eg.Go(func() error {
 			logger.Info("start to delete worker %s", node)
 			if err := k.deleteNode(node); err != nil {