fix: enable tool calling for ChatMLX (fixes langchain-ai/langchain#31… #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for tool/function calling in
ChatMLX
usingMLXPipeline
.Why is this needed?
Fixes a bug where
.tool_calls
was always empty even when a model (e.g.Phi-4-reasoning-plus-MLX-4bit
) supports tool calling.Reference: langchain-ai/langchain#31726
Changes made:
.tool_calls
from the model’s output (if JSON structured)