fix: Retrieve all Slack channels visible to the client #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1kl0sh
changed the title
eyurtsev
reviewed
Jul 7, 2025
| channels = result["channels"] | ||
| public_channels = self._get_all_channels_by_type() | ||
| private_channels = self._get_all_channels_by_type( | ||
| types="private_channel,mpim,im" |
There was a problem hiding this comment.
What was the previous behavior? Was it limited to public channels only?
There was a problem hiding this comment.
Yes, the previous behavior was limited to public channels only (i.e., Slack defaults the types parameter to public_channel). However, after some experimentation, it turned out that if you specify both public_channel and private_channel in the same call, only public channels are returned — hence the change above to separate these calls.
|
@eyurtsev Let me know if there's anything else you'd like me to address. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only retrieved the first page of results returned by the Slack Web API. This PR ensures that we read all pages returned by conversations_list.
Additionally, we now fetch private channels by calling
conversations_listwith the appropriatetypesparameter—public_channelfirst, thenprivate_channel. We make two separate calls because, otherwise, the Slack Web API returns only public channels.