INTPYTHON-687 Add multi_field support for $search operation #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blink1073 The current draft would expect to parse a list of strings -> list of fields to be indexed to the text_key parameter. All other process steps would expect the first key, to be the 'primary key' to read into the page_content field of the Langchain document. What is your opinion on that. Would you prefer a class with like a 'primary' key ? |
|
I like the way you've used it here, it seems intuitive to me. I'm running this branch against our internal CI in addition to the GitHub Actions tests (the link will only work for MongoDB employees): |
|
There are some typing errors |
|
The internal CI build passed |
blink1073
approved these changes
Jul 18, 2025
blink1073
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #165
All tests checked.