INTPYTHON-501 INTPYTHON-784 GraphRAG view and example notebook #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 82ec17a.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…just typing of langchain-mongodb
…ns (langchain-ai#226) Fixes langchain-ai#225 --------- Co-authored-by: Rafael Odon <[email protected]>
[PYTHON-5580](https://jira.mongodb.org/browse/PYTHON-5580) ## Summary <!-- What is this PR introducing? If context is already provided from the JIRA ticket, still place it in the Pull Request as you should not make the reviewer do digging for a basic summary. --> Adds a Pull Request template to this repository based on our new dbx-python code review policy. ## Changes in this PR <!-- What changes did you make to the code? What new APIs (public or private) were added, removed, or edited to generate the desired outcome explained in the above summary? --> * PULL_REQUEST_TEMPLATE.md ## Test Plan <!-- How did you test the code? If you added unit tests, you can say that. If you didn’t introduce unit tests, explain why. All code should be tested in some way – so please list what your validation strategy was. --> Make a PR from this branch to confirm ### Screenshots (optional) <!-- Usually a great supplement to a test plan, especially if this requires local testing. --> ## Checklist <!-- Do not delete the items provided on this checklist --> ### Checklist for Author - [x] Did you update the changelog (if necessary)? **Not necessary** - [x] Is the intention of the code captured in relevant tests? **Not necessary** - [x] If there are new TODOs, has a related JIRA ticket been created? **Not necessary** ### Checklist for Reviewer [@caseyclements, @blink1073] - [x] Does the title of the PR reference a JIRA Ticket? - [x] Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?) - [x] Have you checked for spelling & grammar errors? - [x] Is all relevant documentation (README or docstring) updated? ## Focus Areas for Reviewer <!-- List any complex portion of code you believe needs additional scrutiny and explain why. --> For reviewers provide suggestions on what should be changed about the checklist to better cater to this repository. --------- Co-authored-by: Steven Silvester <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…and cleaned up closing clients (langchain-ai#232) [Issue Key](https://jira.mongodb.org/browse/{ISSUE_KEY}) <!-- What is this PR introducing? If context is already provided from the JIRA ticket, still place it in the Pull Request as you should not make the reviewer do digging for a basic summary. --> <!-- What changes did you make to the code? What new APIs (public or private) were added, removed, or edited to generate the desired outcome explained in the above summary? --> This is a small bugfix. When we switched from including OPENAI_API_KEY in CI secrets to using AZURE_OPENAI_ENDPOINTS, we missed this one. <!-- How did you test the code? If you added unit tests, you can say that. If you didn’t introduce unit tests, explain why. All code should be tested in some way – so please list what your validation strategy was. --> - Tests are run in github and evergreen. A passing patch build will be included. <!-- Do not delete the items provided on this checklist --> - [ na] Did you update the changelog (if necessary)? - [X] Is the intention of the code captured in relevant tests? - [na] If there are new TODOs, has a related JIRA ticket been created? - [X] Has a MongoDB Employee run [the patch build of this PR](https://github.com/mongodb-labs/ai-ml-pipeline-testing?tab=readme-ov-file#running-a-patch-build-of-a-given-pr)? - [x] Does the title of the PR reference a JIRA Ticket? - [x] Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?) - [x] Have you checked for spelling & grammar errors? - [x] Is all relevant documentation (README or docstring) updated? <!-- List any complex portion of code you believe needs particular scrutiny and explain why. --> The author had thought of updating MongoDBGraphStore to be a context manager. All this would do is close the client. We decided to leave it with a close method only.
…ere, and cleared output of cells.
|
Could you address the merge conflicts and rebase to take out the irrelevant changes? |
8 tasks
I've abandoned this PR. The new one is #235. I will sort out errors and include a patch on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
viewandto_networkxmethods toMongoDBGraphStorelangchain-mongodb/libs/langchain-mongodb/examples/GraphRAG.ipynbPassing ai-ml pipeline patch
Focus Areas for Reviewer (optional)