chore(langchain): add ruff rules D (except D100 and D104) #31994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
CodSpeed WallTime Performance ReportMerging #31994 will not alter performanceComparing
|
cbornet
force-pushed
the
langchain-ruff-d-fixes
branch
from
a3130b6 to
63916b4
Compare
CodSpeed Instrumentation Performance ReportMerging #31994 will not alter performanceComparing Summary
|
cbornet
force-pushed
the
langchain-ruff-d-fixes
branch
2 times, most recently
from
1a731d6 to
ff6b28d
Compare
cbornet
changed the title
cbornet
changed the title
cbornet
force-pushed
the
langchain-ruff-d-fixes
branch
from
ff6b28d to
cf6a996
Compare
cbornet
force-pushed
the
langchain-ruff-d-fixes
branch
from
cf6a996 to
dc14217
Compare
cbornet
force-pushed
the
langchain-ruff-d-fixes
branch
3 times, most recently
from
0542395 to
6bfc242
Compare
cbornet
changed the title
cbornet
force-pushed
the
langchain-ruff-d-fixes
branch
from
6bfc242 to
772a1c0
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds additional ruff linting rules from the pydocstyle (D) category except for D100 and D104. The changes focus on enforcing proper docstring formatting standards across the langchain codebase.
Key changes include:
- Standardizing docstring formats to end with periods
- Updating multi-line docstrings to follow proper formatting guidelines
- Removing unnecessary empty lines after docstring opening quotes
- Converting single-line docstrings that spanned multiple lines to proper single-line format
Reviewed Changes
Copilot reviewed 142 out of 143 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pyproject.toml | Expanded ruff rules from D1 to full D suite, added scripts exclusion |
| test files (multiple) | Fixed docstring period endings and multi-line formatting |
| source files (multiple) | Standardized docstring formatting, removed unnecessary empty lines |
| integration test files | Enhanced docstring documentation with proper Args/Returns sections |
cbornet
force-pushed
the
langchain-ruff-d-fixes
branch
2 times, most recently
from
1a788ab to
a91948f
Compare
cbornet
force-pushed
the
langchain-ruff-d-fixes
branch
from
a91948f to
37b593e
Compare
mdrxy
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.astral.sh/ruff/rules/#pydocstyle-d