-
Notifications
You must be signed in to change notification settings - Fork 18.4k
fix(core): implement sleep delay in FakeMessagesListChatModel _generate #32014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…thod Signed-off-by: Siddarthreddygsr <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed WallTime Performance ReportMerging #32014 will not alter performanceComparing
|
CodSpeed Instrumentation Performance ReportMerging #32014 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @eyurtsev for final approval
This looks like a good fix. Have you considered adding a test case to verify that the sleep parameter is respected? This would help prevent regressions in the future. |
+1 on @qwikgig-krishna, some elementary test would be good here |
…tModel Signed-off-by: Siddarthreddygsr <[email protected]>
Added the test case @mdrxy |
implement sleep delay in FakeMessagesListChatModel._generate so the sleep parameter is respected, matching the documented behavior. This adds artificial latency between responses for testing purposes.
Issue: closes #31974 following docs
Dependencies: none
Twitter handle: @siddarthreddyg2