feat(langchain): add ruff rules TRY #32047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
CodSpeed WallTime Performance ReportMerging #32047 will not alter performanceComparing
|
cbornet
commented
Jul 15, 2025
| @@ -178,10 +178,10 @@ def parse(self, text: str) -> dict[str, Any]: | |||
| parsed = parse_and_check_json_markdown(text, expected_keys) | |||
| if not isinstance(parsed["destination"], str): | |||
| msg = "Expected 'destination' to be a string." | |||
| raise ValueError(msg) | |||
| raise TypeError(msg) | |||
There was a problem hiding this comment.
I think here we can replace with TypeError without breaking compatibility since it's wrapped later in a OutputParserException
CodSpeed Instrumentation Performance ReportMerging #32047 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.astral.sh/ruff/rules/#tryceratops-try
noqato not break backward compatibility. The rule is still interesting for new code.