feat(langchain): add ruff rules PL #32079
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
CodSpeed WallTime Performance ReportMerging #32079 will not alter performanceComparing
|
cbornet
force-pushed
the
langchain-ruff-pl
branch
from
4e1f999 to
112a284
Compare
| @@ -87,7 +87,7 @@ def __init__(self, *args: Any, **kwargs: Any): | |||
| ) | |||
| from langchain.chains.hyde.base import HypotheticalDocumentEmbedder as H | |||
|
|
|||
| return H(*args, **kwargs) # type: ignore[return-value] | |||
| return H(*args, **kwargs) # type: ignore[return-value] # noqa: PLE0101 | |||
There was a problem hiding this comment.
Will be fixed by #32078
CodSpeed Instrumentation Performance ReportMerging #32079 will not alter performanceComparing Summary
|
| @@ -89,7 +89,6 @@ def _infer_model_and_provider( | |||
| if provider is None and ":" in model: | |||
| provider, model_name = _parse_model_string(model) | |||
| else: | |||
| provider = provider | |||
There was a problem hiding this comment.
This line was useless
| @@ -10,6 +10,8 @@ class AnyStr(str): | |||
| def __eq__(self, other: object) -> bool: | |||
| return isinstance(other, str) | |||
|
|
|||
| __hash__ = str.__hash__ | |||
There was a problem hiding this comment.
This is rule PLW1641: https://docs.astral.sh/ruff/rules/eq-without-hash/
cbornet
force-pushed
the
langchain-ruff-pl
branch
from
112a284 to
1cfe00d
Compare
cbornet
force-pushed
the
langchain-ruff-pl
branch
from
1cfe00d to
b5ef32e
Compare
| "C4", # flake8-comprehensions | ||
| "COM", # flake8-commas | ||
| "D", # pydocstyle | ||
| "DOC", # pydoclint |
There was a problem hiding this comment.
DOC is currently a preview rule.
There’s no point in activating it as we don’t run with the —preview flag.
And we get a warning about it when running the lint.
See https://docs.astral.sh/ruff/rules/#pylint-pl