Skip to content

feature: added support for POST to ApiChain #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

feature: added support for POST to ApiChain #1432

wants to merge 10 commits into from

Conversation

@vjsai
Copy link
Contributor

@vjsai vjsai commented May 28, 2023 •
edited
Loading

added support for POST to ApiChain

  • Changed Prompt to support POST call as well
  • Made code changes to support POST via fetch

@vercel
Copy link

vercel bot commented May 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jun 8, 2023 3:42am

vjsai
vjsai commented May 28, 2023
View reviewed changes
jacoblee93
jacoblee93 reviewed May 28, 2023
View reviewed changes
jacoblee93
jacoblee93 reviewed May 28, 2023
View reviewed changes
jacoblee93
jacoblee93 requested changes May 28, 2023
View reviewed changes
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the idea, a few comments though!

@jacoblee93 jacoblee93 self-assigned this May 28, 2023
@jacoblee93 jacoblee93 added the in progress PRs that are in progress but not ready to merge label May 28, 2023
@vjsai
added StructuredOutputParser and
1404546 
OutputFixingParser
addressed review comments
@vjsai
Copy link
Contributor Author

vjsai commented May 29, 2023

@jacoblee93 Can you review and let me know if there are any other inputs. Thanks!

jacoblee93
jacoblee93 reviewed May 29, 2023
View reviewed changes
jacoblee93
jacoblee93 reviewed May 29, 2023
View reviewed changes
@jacoblee93 jacoblee93 added close PRs that need one or two touch-ups to be ready and removed in progress PRs that are in progress but not ready to merge labels May 29, 2023
@jacoblee93
Copy link
Collaborator

A few more comments!

vjsai added a commit to vjsai/langchain-hub that referenced this pull request May 29, 2023
@vjsai
Update chain.json
44186b7 
Updated the API Chain for newer changes as reference to langchain-ai/langchainjs#1432
@vjsai vjsai mentioned this pull request May 29, 2023
Open
@vjsai
Copy link
Contributor Author

vjsai commented May 29, 2023

@jacoblee93 addressed the comments and also raised PR for LC hub as well. Let me know if anything more needs to be added. Thanks!

@vjsai
Copy link
Contributor Author

vjsai commented Jun 6, 2023

@jacoblee93 Have addressed review comments let me know if I am missing something. Thanks !

@vjsai vjsai requested a review from jacoblee93 June 6, 2023 20:12
@jacoblee93
Copy link
Collaborator

Hey @vjsai, sorry for the delay. I actually think we should think a bit more about the effect on existing folks using this before making a big prompt change - I'd be more open to adding this as an extension (use a different prompt if the user wants to enable the chain to use different methods) if you're open to that?

@jacoblee93 jacoblee93 added the question Further information is requested label Jun 6, 2023
@vjsai
Copy link
Contributor Author

vjsai commented Jun 7, 2023

Makes sense @jacoblee93. So should we keep the existing prompt as is and give user ability to change the prompt as well as parsing logic for the response from prompt in that case then ? Would this change be ok ? Let me know your thoughts on what changes do I need to make will make them. Thanks!

@jacoblee93
Copy link
Collaborator

Now that #1803 is merged I think this is superseded - sorry for the confusion.

@jacoblee93 jacoblee93 closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacoblee93 jacoblee93 Awaiting requested review from jacoblee93

Assignees

@jacoblee93 jacoblee93

Labels

close PRs that need one or two touch-ups to be ready question Further information is requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vjsai @jacoblee93