See #8405 Add support for token usage details in TokenUsage #8407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
auto:improvement
|
Thanks @a-i-joe for the contribution 🙏 I will take this to the team and discuss if this is something we would be interested adding. Let me get back on this soon. |
hntrl
reviewed
Sep 10, 2025
There was a problem hiding this comment.
Hey @a-i-joe! Two things regarding this PR:
- The TokenUsage object that you're targeting here is for legacy
Generationobjects that we don't surface to the user unless you're using deprecated methods likegeneratePromptorcall. If you want to surface these tokens fromChatOpenAI.invoke, the thing we'd want to update is the usage metadata. (we're looking to nix the Generation object in an effort to make things more clear) - I don't think we want to supply openai only properties on token count objects, since the implication is that we can provide it across all providers. We are working on some enhancements to message objects that will let you specify arbitrary properties per provider, so I can give you an update
I've converted the discussion post into an issue (#8906) since I do think it would be a good thing to add, but we'll likely target this in v1 off the back of the messages changes I mentioned. In the mean time, I'm going to close this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the core interface for TokenUsage with new optional fields to contain details such as cached tokens and reasoning tokens.
Updates the OpenAI mapping into TokenUsage to take advantage of the new details fields.
Fixes #8405