fix(pgvector): add skipInitializationCheck option to disable schema c… #8414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
auto:improvement
|
Hi @hntrl 👋 quick ping! This PR is important for security-sensitive environments. It’s marked size:L mainly due to tests, but the change is simple. Appreciate a review — thanks! 🚀 |
|
Hi @hntrl! Sorry for pinging you again, but did you have the chance to review this pull request? I know you guys work hard on this library and I really appreciate that. Thanks a lot for building it. |
|
thanks for the ping and the kind words! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
skipInitializationCheckoption inPgVectorStore, allowing users to disable automatic schema modification during initialization (i.e.,CREATE EXTENSIONandCREATE TABLE).This improves compatibility with production environments where database credentials are restricted and schema-altering permissions are not granted (e.g., cloud deployments following the principle of least privilege).
Changes:
skipInitializationCheckoption toPgVectorStoreensureTableInDatabaselogic if the flag is enabledFixes #8401