improve bm25 sorting function #8427
Open
+41
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
auto:improvement
AllenFang
force-pushed
the
chore/use-default-bm25-sorter
branch
from
6af9ed3 to
559f7c0
Compare
AllenFang
force-pushed
the
chore/use-default-bm25-sorter
branch
from
559f7c0 to
2521fdd
Compare
AllenFang
commented
Jun 27, 2025
|
|
||
| export interface BMInputDocument<T> { | ||
| /** The text from the original document */ | ||
| text: string; |
There was a problem hiding this comment.
let me know if team prefer to use a method to extract the text rather than adding another text field BMInputDocument:
ex:
export interface BMInputDocument<T> {
extractText: (docs: T) => string;
/** The original document */
docs: T;
}
|
@AllenFang thanks for the PR 🙏 do you think we can add some unit tests to verify the changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal:
sortermethod signature ofBM25BM25method to solve the problem if sorter param assign, it's very difficult to map the result to original data.BM25methoddocs