-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(ollama): Add think Field to ChatOllama for Controlling Thought Process in Responses #8494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… does not have <think>.*?</think>
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
@hntrl @jacoblee93 Could you please take a moment to review the six workflows that are currently awaiting your approval? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rliu6915 for raising the PR 🎉 I have some minor suggestions, wdyt?
Co-authored-by: Christian Bromann <[email protected]>
Co-authored-by: Christian Bromann <[email protected]>
Wait this PR |
Hi, for Ollama js, thinking mode was introduced in v0.5.16. So I updated Ollama to 0.5.17 (the latest). @hntrl @jacoblee93 @christian-bromann Could you please review the change that is awaiting your approval? |
Hi, sorry, it failed this time because of yarn check. I yarned format, updated the code, yarned format:check and matched like below: ![]() @hntrl @jacoblee93 @christian-bromann Could you please review the change that is awaiting your approval? |
@rliu6915 apologies 1000x for taking this long to get this landed. Thank you for your persistence and for the PR! 💪 |
This change resolves the issue where users using thinking model such as Deepseek-r1-32b couldn't hide thought process when they are using Ollama through langchain.js framework's Ollama integration. Previously, attempting to use thinking model such as deepssek with thinking mode set to false. output would still result in a response with a combination of thinking and content.
The fix includes:
Fixes #8481