Skip to content

Conversation

princethirstydevs
Copy link

Fixes #8503

Copy link

vercel bot commented Jul 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jul 15, 2025 9:55am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Jul 15, 2025 9:55am

@hntrl
Copy link
Member

hntrl commented Jul 29, 2025

Hey @princethirstydevs! Appreciate you taking the time to make a PR.

Just returning the response from the implementation violates the types of the core abstraction, which is something we don't want. I left some comments in the linked issue to maybe help paint a clearer picture.

@hntrl hntrl closed this Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addDocument() & addVectors() missing response in Milvus
2 participants