-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(google/v1): V1 testing and support for google-common based packages #9194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v1
Are you sure you want to change the base?
Conversation
Switch from jest to vitest Regression testing ok
Switch from jest to vitest Regression testing acceptable
Switch from jest to vitest Regression testing acceptable
Switch from jest to vitest Regression testing acceptable
Switch from jest to vitest Regression testing acceptable
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these scripts will need to be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed that one. Thank you for catching.
Updated these scripts.
| @@ -28,7 +28,9 @@ import { BlobStoreGoogleCloudStorage } from "../media.js"; | |||
|
|
|||
| describe("GAuth Chat", () => { | |||
| test("invoke", async () => { | |||
| const model = new ChatGoogle(); | |||
| const model = new ChatGoogle({ | |||
| modelName: "gemini-2.0-flash", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not blocking, but we're preferring model for this field name
|
Deployment failed with the following error: |
This ensures that the google-common based libraries will work with v1 libraries. Primary tasks were:
(Review of what I've done so far appreciated @hntrl @christian-bromann to make sure this is on the right track for v1.)
TODO:
Desirable:
ContentBlocksupport