Fix: Remove duplicate /mcp path append in agent MCP URL update script #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script was appending /mcp to the MCP server URL before storing it in agent configurations. However, the LangGraph agent runtime also appends /mcp when making requests, resulting in double-appended paths like /mcp/mcp that return 404 errors. This fix removes the path append from the script, allowing agents to correctly construct MCP server URLs at runtime. Fixes authentication issues where 404 errors triggered fallback auth flows.
|
@tim-yung is attempting to deploy a commit to the LangChain Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script (
apps/web/scripts/update-agents-mcp-url.ts) was appending /mcp to the MCP server URL before storing it in agent configurations. However, the LangGraph agent runtime also appends /mcp when making requests, resulting in double-appended paths like /mcp/mcp that return 404 errors.Line 192, oap-langgraph-tools-agent/tools_agent/agent.py:
This fix removes the path append from the script, allowing agents to correctly construct MCP server URLs at runtime.
Fixes authentication issues where 404 errors triggered fallback auth flows.