Skip to content

[12.x] Make Boolean:strict validation case-insensitive for parameter value #56320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[12.x] Make Boolean:strict validation case-insensitive for parameter value #56320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d2586d
fix boolean:strict validation
amirhshokri Jul 17, 2025
e984fae
fix deprecation tests
amirhshokri Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Illuminate/Validation/Concerns/ValidatesAttributes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ public function validateBoolean($attribute, $value, $parameters)
{
$acceptable = [true, false, 0, 1, '0', '1'];

if (($parameters[0] ?? null) === 'strict') {
if (isset($parameters[0]) && strtolower($parameters[0]) === 'strict') {
$acceptable = [true, false];
}

Expand Down
76 changes: 76 additions & 0 deletions tests/Validation/ValidationValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3154,6 +3154,44 @@ public function testValidateBooleanStrict()
$this->assertFalse($v->passes());
}

public function testValidateBooleanStrictWithUpperCase()
{
$trans = $this->getIlluminateArrayTranslator();

$v = new Validator($trans, ['foo' => false], ['foo' => 'Boolean:STRICT']);
$this->assertTrue($v->passes());

$v = new Validator($trans, ['foo' => true], ['foo' => 'Boolean:STRICT']);
$this->assertTrue($v->passes());

$v = new Validator($trans, ['foo' => 'no'], ['foo' => 'Boolean:STRICT']);
$this->assertFalse($v->passes());

$v = new Validator($trans, ['foo' => 'yes'], ['foo' => 'Boolean:STRICT']);
$this->assertFalse($v->passes());

$v = new Validator($trans, ['foo' => 'false'], ['foo' => 'Boolean:STRICT']);
$this->assertFalse($v->passes());

$v = new Validator($trans, ['foo' => 'true'], ['foo' => 'Boolean:STRICT']);
$this->assertFalse($v->passes());

$v = new Validator($trans, [], ['foo' => 'Boolean:STRICT']);
$this->assertTrue($v->passes());

$v = new Validator($trans, ['foo' => '1'], ['foo' => 'Boolean:STRICT']);
$this->assertFalse($v->passes());

$v = new Validator($trans, ['foo' => 1], ['foo' => 'Boolean:STRICT']);
$this->assertFalse($v->passes());

$v = new Validator($trans, ['foo' => '0'], ['foo' => 'Boolean:STRICT']);
$this->assertFalse($v->passes());

$v = new Validator($trans, ['foo' => 0], ['foo' => 'Boolean:STRICT']);
$this->assertFalse($v->passes());
}

public function testValidateBool()
{
$trans = $this->getIlluminateArrayTranslator();
Expand Down Expand Up @@ -3229,6 +3267,44 @@ public function testValidateBoolStrict()
$this->assertFalse($v->passes());
}

public function testValidateBoolStrictWithUpperCase()
{
$trans = $this->getIlluminateArrayTranslator();

$v = new Validator($trans, ['foo' => false], ['foo' => 'Bool:STRICT']);
$this->assertTrue($v->passes());

$v = new Validator($trans, ['foo' => true], ['foo' => 'Bool:STRICT']);
$this->assertTrue($v->passes());

$v = new Validator($trans, ['foo' => 'no'], ['foo' => 'Bool:STRICT']);
$this->assertFalse($v->passes());

$v = new Validator($trans, ['foo' => 'yes'], ['foo' => 'Bool']);
$this->assertFalse($v->passes());

$v = new Validator($trans, ['foo' => 'false'], ['foo' => 'Bool:STRICT']);
$this->assertFalse($v->passes());

$v = new Validator($trans, ['foo' => 'true'], ['foo' => 'Bool:STRICT']);
$this->assertFalse($v->passes());

$v = new Validator($trans, [], ['foo' => 'Bool:STRICT']);
$this->assertTrue($v->passes());

$v = new Validator($trans, ['foo' => '1'], ['foo' => 'Bool:STRICT']);
$this->assertFalse($v->passes());

$v = new Validator($trans, ['foo' => 1], ['foo' => 'Bool:STRICT']);
$this->assertFalse($v->passes());

$v = new Validator($trans, ['foo' => '0'], ['foo' => 'Bool:STRICT']);
$this->assertFalse($v->passes());

$v = new Validator($trans, ['foo' => 0], ['foo' => 'Bool:STRICT']);
$this->assertFalse($v->passes());
}

public function testValidateNumeric()
{
$trans = $this->getIlluminateArrayTranslator();
Expand Down