[12.x] Refactor Unify DocBlock return types for functions with possib… #56323
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions in Laravel have a return type of mixed, while the function may also work as void. To make this clearer, I changed the Doc Blocks to be more explicit. Although I have seen that in one place in the framework this situation is written as
mixed|null
, in my opinion it is better to have a consistent style everywhere, meaning either usemixed|void
ormixed|null
.If this style is not correct, please let me know so I can change it to something else.
Sample One:
framework/src/Illuminate/Console/Concerns/InteractsWithIO.php
Lines 248 to 278 in 2c682e4
Sample Two:
framework/src/Illuminate/Database/Eloquent/Concerns/HasEvents.php
Lines 229 to 247 in 2c682e4