[12.x] Add support for expected exit codes in the scheduler #56329
+123
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scheduled command return code checking was introduced in #55624, however sometimes non 0 return codes can also be considered successful (especially when running external programs with the
exec
call)Solution
This PR introduces two new methods on the scheduled event:
allowExitCode
which can be used to allow additional exit code(s) for the commandallowFailures
which can be used to accept all exit codesAdditionally a new exception is also introduced for the unexpected exit codes so it could be handled in the exception handler.
Examples
Backwards compatibility
If required I can also make a PR for the docs after this is merged. Please also let me know if any naming should be changed or any type hints should be removed.