Fix/routing response factory method signature #56483
Closed
+847
−552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
* fetchargs * add fetchArgs() function * fetchargs * add fetchArgs() function * add afterquery callbacks * fix typo * flip afterquerycallback * fix expectations * add expectations * add expectations * add expectations * add raw expression test * rename to fetchUsing * style * Remove test from PR laravel#54396 * Revert most Query\Builder changes * remove DB::raw test * Revert QueryBuilder pluck tests * Add base tests for $query->fetchUsing() * style * formatting * Update Builder.php * Fix filled columns before calling pluck * query db compatibility --------- Co-authored-by: Taylor Otwell <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
* Add tests * Remove any scopes removed in a nested where * Update tests to expect calls to `removedScopes`
* Remove function existence checks * remove unused JsonException import --------- Co-authored-by: Xurshudyan <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
* fetchargs * add fetchArgs() function * fetchargs * add fetchArgs() function * add afterquery callbacks * fix typo * flip afterquerycallback * fix expectations * add expectations * add expectations * add expectations * add raw expression test * rename to fetchUsing * style * Remove test from PR laravel#54396 * Revert most Query\Builder changes * remove DB::raw test * Revert QueryBuilder pluck tests * Add base tests for $query->fetchUsing() * style * formatting * Update Builder.php * Fix filled columns before calling pluck * query db compatibility * remove unrelated test --------- Co-authored-by: Taylor Otwell <[email protected]>
…el#55508) * Allow Listeners to dynamically specify deleteWhenMissingModels * Update BroadcastEvent.php * Update CallQueuedListener.php --------- Co-authored-by: Taylor Otwell <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
…ravel#55685) * Add failing test * Only mark a model class as booted after the boot process has been completed * Mark a model class as booting as soon as the boot process starts - A model class is removed from the `booting` array as soon as the boot process has completed. * Throw an exception if `bootIfNotBooted` is called while booting - This infers that something in the boot process expected the boot to already be finished. - If we just ignore the call then the model class would be in an inconsistent state for whichever code called it. * formatting * formatting --------- Co-authored-by: Taylor Otwell <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
It still works, because of php case sensitive rules, but it's better correct.
* feat: add support in grammar * feat: add functions in builder * test: add tests * test: adjust syntax mysql * test: adjust syntax mysql * test: remove line noused * test: execute compileJoins * formatting --------- Co-authored-by: Taylor Otwell <[email protected]>
… a domain (laravel#55921) * wip * wip * wip * linting
Signed-off-by: Mior Muhammad Zaki <[email protected]>
* [13.x] Supports Symfony 7.4 Signed-off-by: Mior Muhammad Zaki <[email protected]> * Update `Application` to use `addCommand` insteads of deprecated `add` Signed-off-by: Mior Muhammad Zaki <[email protected]> * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * Remove `addToParent()` method. Signed-off-by: Mior Muhammad Zaki <[email protected]> * Revert "Remove `addToParent()` method." This reverts commit 7cf2aa7. * wip Signed-off-by: Mior Muhammad Zaki <[email protected]> * Update Application.php --------- Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
* Change to hyphenate prefixes * Use `Str::snake()` as intended
* remove superfluous element we don't need both the `<div>` and the `<p>` elements, as their purpose can be handled by a single `<div>`. while minor, having less DOM is always better for performance. * do the same for the BS5 view
Adds `eventStream` to `Illuminate\Contracts\Routing\ResponseFactory` in order to add type support for this method, aligning this with the same behavior that we have for `stream` of which `eventStream` is a convenient wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Align ResponseFactory::eventStream signature with interface
Summary
This PR fixes a method signature mismatch in
Illuminate\Routing\ResponseFactory::eventStreamthat was causing fatal errors in tests.Problem
PR #56306 added the
eventStreammethod signature to theIlluminate\Contracts\Routing\ResponseFactoryinterface to improve type support and static analysis. However, the existing concrete implementation inIlluminate\Routing\ResponseFactoryuses type hints that don't match the interface declaration, creating a fatal error: