[12.x] Refactor the duplicate code by extracting it into a reusable method. #57531
+15
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors repetitive logic in the
Illuminate\Routing\RouteCollectionclass related to populating the$nameListlookup array. Previously, bothrefreshNameLookups()andaddLookups()contained duplicated code for checking and assigning named routes to the lookup table.✅ Improvements included in this PR:
addToNameLookup()method.refreshNameLookups()now delegates to the new helper method.Why?
This cleanup:
Before
Logic duplicated inside both:
addLookups()refreshNameLookups()After
Single clean implementation:
addLookups()→ callsaddToNameLookup()refreshNameLookups()→ callsaddToNameLookup()during iterationTests
No functional modifications, so no new tests were required. All existing route tests already pass with these changes.