Skip to content

Conversation

@AhmedAlaa4611
Copy link
Contributor

Description

From PR #53835, I understand that we can run Laravel Pint before committing changes. However, when I make a fresh clone of the repository and run:

./vendor/bin/pint --dirty

I get 2,547 files with 2,535 style issues most of them related to the line_ending rule.

Additionally, there are several differences between Pint's rules and StyleCI's configuration. For example, the following rules are applied to the types/Support/Collection.php file:

align_multiline_comment, line_ending, unary_operator_spaces, not_operator_with_successor_space, no_extra_blank_lines, blank_line_between_import_groups

Motivation

As @crynobone said:

StyleCI handles styling errors for us without thinking about formatting. We never reject PRs if CI only failed due to StyleCI pipeline.

All these will adds additional work to maintainers when it was never been an issue at the moment.

Steps to Reproduce

  • Clone this repository.
  • Run: ./vendor/bin/pint.
  • Notice the formatting differences between Pint and StyleCI.
  • Open a PR with those changes 😂.
  • Wait for StyleCI to revert them 😂.

@browner12
Copy link
Contributor

Disagree. IMO we should be dropping StyleCI, and I've been gearing up at another attempt at just that.

@NickSdot
Copy link
Contributor

Something has to happen here tbh.

StyleCI and Pint use PHP CS Fixer under the hood. Why isn't the same rule set used?

If Pint is meant to be for application code only, it should be removed here and only be part of laravel/laravel. If not, StyleCI should be aligned to use the same rules as Pint.

@AhmedAlaa4611
Copy link
Contributor Author

AhmedAlaa4611 commented Oct 26, 2025

If both StyleCI and Pint use PHP CS Fixer under the hood we should drop StyleCI from here and rely on Pint for developing our applications as well as contributing to the core.

@browner12 What is your opinion about drafting this and wait for your PR to drop StyleCI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants