Avoid PHP 8.2+ null deprecation in hasher check #57543
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to password_verify() This PR updates the `Illuminate\Hashing\AbstractHasher::check()` method to prevent PHP 8.2+ from throwing a deprecation warning when null or non-string values are passed to `password_verify()`. In PHP 8.2 and later, passing `null` to functions that expect `string` parameters (like `password_verify()`) is deprecated. Under some authentication edge cases, `$value` or `$hashedValue` can be `null` before validation, which triggers this warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
Illuminate\Hashing\AbstractHasher::check()method to prevent PHP 8.2+ from throwing a deprecation warning when null or non-string values are passed topassword_verify().In PHP 8.2 and later, passing
nullto functions that expectstringparameters (likepassword_verify()) is deprecated. Under some authentication edge cases,$valueor$hashedValuecan benullbefore validation, which triggers this warning.