[12.x] Queue tests for Redis Cluster missing QUEUE_CONNECTION #57641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
vadimonus
force-pushed
the
queue-tests-missing-connection
branch
6 times, most recently
from
1eba82a to
c5566d8
Compare
vadimonus
force-pushed
the
queue-tests-missing-connection
branch
2 times, most recently
from
6c0f5d2 to
d533be3
Compare
vadimonus
force-pushed
the
queue-tests-missing-connection
branch
from
d533be3 to
810e909
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suddenly found out that QUEUE_CONNECTION is not set for Redis Cluster queue integration tests. This leads to using of default connection (sync) in some tests and not really testing integration where it should.
This PR fixes this issue, and adds calling setUpRedis in QueueTestCase to properly setup Redis Cluster connection.
It also adds jobs order asserts for non-sync queues in JobChainingTest for better behaviour coverage.
Sometimes Redis Cluster was not ready to serve requests at the start of test (previously this problem was not seen, because first tests in list really used sync driver and did not communicated with Redis). Added action to check if cluster is ready before starting tests.